Skip to content

Conversation

oscarog
Copy link
Member

@oscarog oscarog commented Nov 13, 2026 •

Purpose

Allow users to save and manage their own PC builds across sessions, with authentication and ownership enforced by the GraphQL API.

Changes

  • Add Firebase Google and email/password login, registration, and logout.
  • Link Firebase accounts to users in PostgreSQL.
  • Add My builds with private/published labels and keyboard-accessible cards.
  • Support reopening, updating, publishing, copying, and deleting owned builds.
  • Restrict Community to published builds and preserve ownerless legacy builds.
  • Document the authentication provider comparison and database setup.
  • Integrate with dev’s routing, component structure, request limits, and query batching.

Related issues

Closes #97

Verification

  • Frontend: npm run lint, npm run build, and npm test passed, 97 tests.
  • Backend: npm run lint and npm test passed, 95 tests, including the TypeScript build.
  • Authorization tests cover two user identities, private access, owner-only updates/deletion, and legacy builds using isolated database fixtures.
  • Login and backend user creation were manually tested locally.
  • Final deployed VM smoke testing remains outstanding.

Screenshots

Skjermbilde 2026-11-13 kl  23 36 22 Skjermbilde 2026-11-13 kl  23 36 39 Skjermbilde 2026-11-13 kl  23 36 57

Checklist

  • I have reviewed my own changes.
  • The changes meet the linked issue's acceptance criteria, where applicable.
  • I have verified the changes and recorded the results above.
  • I have added or updated tests where needed.
  • I have updated documentation where needed.
  • I have included screenshots for visual changes, or marked them not applicable.

Oscar Grande added 9 commits November 11, 2026 21:11
- Added OpenSavedBuild component to handle loading saved builds in the PC Builder.
- Updated PcBuilderPage to integrate OpenSavedBuild and display editing status for saved builds.
- Created AccountPage to manage user accounts and display their builds.
- Implemented DeleteBuildButton for deleting builds with confirmation dialog.
- Enhanced backend tests for build ownership and authorization.
- Expanded frontend tests for saved build workflows and delete functionality.
- Updated README with new test results and coverage.
…to 97-implement-user-authentications-and-build-ownership
@oscarog oscarog self-assigned this Nov 13, 2026
@oscarog oscarog requested a review from a team as a code owner November 13, 2026 22:38
Copy link
Member

@ludvigz ludvigz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be ready for deliverable 4 after we get the README up to date

@ludvigz ludvigz merged commit 270ca15 into dev Nov 13, 2026
@ludvigz ludvigz deleted the 97-implement-user-authentications-and-build-ownership branch November 13, 2026 22:40
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants